Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the Source. #9

Merged
merged 4 commits into from
Oct 27, 2022
Merged

Add tests to the Source. #9

merged 4 commits into from
Oct 27, 2022

Conversation

voscob
Copy link
Contributor

@voscob voscob commented Oct 26, 2022

Description

I've added unit and integration tests to the Source.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@voscob voscob requested review from maksenius and oykmnk October 26, 2022 20:55
* Add the acceptance test

* Wrap config errors

* Remove the unnecessary link to the source from the method's description of the acceptance test
@voscob voscob merged commit 0418cd8 into feature/source Oct 27, 2022
@voscob voscob deleted the feature/source-tests branch October 27, 2022 18:17
voscob added a commit that referenced this pull request Nov 9, 2022
* Add a source config

* Implement the Source methods

* Update comments of the config fields

* Update the Source

* Wrap config errors

* Remove unnecessary iterator parameter

* Add tests to the Source. (#9)

* Fix the db in the Destination

* Add tests for the Source

* Add the acceptance test (#10)

* Add the acceptance test

* Wrap config errors

* Remove the unnecessary link to the source from the method's description of the acceptance test

* Update the comment of the randString Source method

* Add the information about the Source (#11)

* Add the information about the Source

* Add the example of the position

* Add some updates

* Update the info about the iterator

* Add the information about the CDC

* Rename a counter variable in the acceptance test

* Extend the test case to test the parsing of column fields

* Update logic of separated by comma fields, refactoring of tests (#12)

* Update logic of separated by comma fields, refactoring of tests

* Remove unnecessary strings.Trim calls

* Update readme.md

* Add info about Log engines to the

* Add the check engines test case

* Rename test constants

* Update readme.md

* Update column names in the integration test

* Update Source Parameters

* Update the names of columns in the acceptance test

* Update readme.md

* Update the check engines integration test

* Update readme.md
voscob added a commit that referenced this pull request Nov 9, 2022
* Add a general config with a validator

* Add columntypes

* Add the destination

* Move the error from the  to the  file

* Add the unit test for the columntypes

* Add unit tests for destination and writer

* Update the comment bellow the  error

* Remove a repository package

* Use the  method instead of a switch in the  method

* Update the Writer interface

* Remove the  config field

* Update the destination unit test

* Add Yalantis to the copyright header

* Add a destination integration test

* Update the  with the destination info

* remove comment

* refactor readme

* Update the destination unit test

* Add more types to the destination integration test

* Add the explanation why the connector does not contain an sql-builder

* Update

* Add the keyColumn config

* Move the keyColumn configuration field to the destination config

* Add logs into the destination

* Remove unnecessary constants from the writer.go

* Add a few failed unit tests for the Write method

* Update the Destination Configure unit test

* Remove Parallel signals from the integration test

* Extend the table with configuration options with sdk.rate parameters

* Update the

* Move  methods into the  package

* Fix the db in the Destination

* Wrap config errors

* Move variables to consts in unit-tests

* Rename parse configuration function

* Update comments

* Rename test constants

* Rename test constants

* Update Destination Parameters

* Update the names of columns in the destination integration test

* Add engines destination test (#14)

* Add engines destination test

* Update comment line

* Add the Source (#8)

* Add a source config

* Implement the Source methods

* Update comments of the config fields

* Update the Source

* Wrap config errors

* Remove unnecessary iterator parameter

* Add tests to the Source. (#9)

* Fix the db in the Destination

* Add tests for the Source

* Add the acceptance test (#10)

* Add the acceptance test

* Wrap config errors

* Remove the unnecessary link to the source from the method's description of the acceptance test

* Update the comment of the randString Source method

* Add the information about the Source (#11)

* Add the information about the Source

* Add the example of the position

* Add some updates

* Update the info about the iterator

* Add the information about the CDC

* Rename a counter variable in the acceptance test

* Extend the test case to test the parsing of column fields

* Update logic of separated by comma fields, refactoring of tests (#12)

* Update logic of separated by comma fields, refactoring of tests

* Remove unnecessary strings.Trim calls

* Update readme.md

* Add info about Log engines to the

* Add the check engines test case

* Rename test constants

* Update readme.md

* Update column names in the integration test

* Update Source Parameters

* Update the names of columns in the acceptance test

* Update readme.md

* Update the check engines integration test

* Update readme.md

Co-authored-by: Yurii Voskoboinikov <voscob@gmail.com>
voscob added a commit that referenced this pull request Nov 9, 2022
* Add a source config

* Implement the Source methods

* Update comments of the config fields

* Update the Source

* Wrap config errors

* Remove unnecessary iterator parameter

* Add tests to the Source. (#9)

* Fix the db in the Destination

* Add tests for the Source

* Add the acceptance test (#10)

* Add the acceptance test

* Wrap config errors

* Remove the unnecessary link to the source from the method's description of the acceptance test

* Update the comment of the randString Source method

* Add the information about the Source (#11)

* Add the information about the Source

* Add the example of the position

* Add some updates

* Update the info about the iterator

* Add the information about the CDC

* Rename a counter variable in the acceptance test

* Extend the test case to test the parsing of column fields

* Update logic of separated by comma fields, refactoring of tests (#12)

* Update logic of separated by comma fields, refactoring of tests

* Remove unnecessary strings.Trim calls

* Update readme.md

* Add info about Log engines to the

* Add the check engines test case

* Rename test constants

* Update readme.md

* Update column names in the integration test

* Update Source Parameters

* Update the names of columns in the acceptance test

* Update readme.md

* Update the check engines integration test

* Log warnings if the table engine does not support an update or delete operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants